Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ash/device: Add missing Device::get_device_queue2() wrapper #736

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

phoekz
Copy link
Contributor

@phoekz phoekz commented Apr 7, 2023

No description provided.

@MarijnS95 MarijnS95 changed the title Add vkGetDeviceQueue2 ash/device: Add missing Device::get_device_queue2() wrapper Apr 7, 2023
Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, glad you spotted the missing function!

Could you by chance move this function in between trim_command_pool and create_sampler_ycbcr_conversion, so that the order matches vk.xml and DeviceFnV1_1?

Don't forget to mention this fix in the changelog:

 - Added `VK_EXT_shader_object` device extension (#732)
+- Added missing `Device::get_device_queue2()` wrapper (#736)

Comment on lines 947 to 949
pub unsafe fn get_device_queue2(&self, create_info: &vk::DeviceQueueInfo2) -> vk::Queue {
let mut queue = mem::zeroed();
(self.device_fn_1_1.get_device_queue2)(self.handle(), create_info, &mut queue);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just had a big push to rename create_info to a more descriptive name in most function signatures (even though this function sort-of creates/gets a handle to a queue), i.e. the one provided by the bindings. That'd be queue_info in this case:

Suggested change
pub unsafe fn get_device_queue2(&self, create_info: &vk::DeviceQueueInfo2) -> vk::Queue {
let mut queue = mem::zeroed();
(self.device_fn_1_1.get_device_queue2)(self.handle(), create_info, &mut queue);
pub unsafe fn get_device_queue2(&self, queue_info: &vk::DeviceQueueInfo2) -> vk::Queue {
let mut queue = mem::zeroed();
(self.device_fn_1_1.get_device_queue2)(self.handle(), queue_info, &mut queue);

@MarijnS95 MarijnS95 merged commit 88e46b4 into ash-rs:master Apr 8, 2023
MarijnS95 pushed a commit that referenced this pull request Apr 8, 2023
ash/device: Add missing Device::get_device_queue2() wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants