extensions/ext: Make get_calibrated_timestamps() return single value for max_deviation
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
get_calibrated_timestamps return (Vec<u64>, u64)get_calibrated_timestamps return single value for maxDeviation
Ralith
approved these changes
Apr 9, 2023
MarijnS95
changed the title
get_calibrated_timestamps return single value for maxDeviationget_calibrated_timestamps return single value for max_deviation
|
Can you make the changelog entry similar to the changed title? And do you want this to be backported to 37.3, in which case we need to |
MarijnS95
changed the title
get_calibrated_timestamps return single value for max_deviationget_calibrated_timestamps() return single value for max_deviation
…e for `max_deviation` Per spec `max_deviation` is a single value, not an array.
MarijnS95
approved these changes
May 6, 2023
|
I'm fine not backporting this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec
max_deviationis a single value, and not a vector.Closes #737