Expose FramebufferCreateInfo::attachment_count builder for IMAGELESS
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't omit the `attachment_count()` builder method, because it is valid to set the number of attachments without providing attachments in the `IMAGELESS` case. Also change the generator array lookup to use the name of the count field that is allowed to have a builder method, rather than the name of the field that would use this as `len` field and hence cause it to be skipped.
Ralith
approved these changes
May 1, 2023
MarijnS95
added a commit
to Traverse-Research/ash
that referenced
this pull request
May 2, 2023
MarijnS95
added a commit
that referenced
this pull request
May 2, 2023
…SS` (#747) * Expose `FramebufferCreateInfo::attachment_count` builder for `IMAGELESS` Don't omit the `attachment_count()` builder method, because it is valid to set the number of attachments without providing attachments in the `IMAGELESS` case. Also change the generator array lookup to use the name of the count field that is allowed to have a builder method, rather than the name of the field that would use this as `len` field and hence cause it to be skipped. * Clean up clones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450
Don't omit the
attachment_count()builder method, because it is valid to set the number of attachments without providing attachments in theIMAGELESScase.Also change the generator array lookup to use the name of the count field that is allowed to have a builder method, rather than the name of the field that would use this as
lenfield and hence cause it to be skipped.