extensions/ext: Add VK_EXT_host_image_copy #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
ext-host-image-copy
branch
from
23de7d6
to
3e95bb2
Compare
MarijnS95
commented
Jul 31, 2023
Comment on lines
+26
to
+29
| /// Also available as [`HostImageCopy::get_image_subresource_layout2()`] | ||
| /// when [`VK_EXT_host_image_copy`] is enabled. | ||
| /// | ||
| /// [`VK_EXT_host_image_copy`]: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_host_image_copy.html |
There was a problem hiding this comment.
Still unsure if this is an OR or AND... Maybe an AND in the case that vk::Image lives on the host?
There was a problem hiding this comment.
I figured it's an OR. In vk.xml both extensions have this command inside a <require> block, without extra depends="the_other_extension" attribute.
This was referenced Jul 31, 2023
MarijnS95
force-pushed
the
ext-host-image-copy
branch
from
3e95bb2
to
f3e212f
Compare
MarijnS95
changed the title
MarijnS95
force-pushed
the
ext-host-image-copy
branch
from
f3e212f
to
803d184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.