Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: revert API 29 test to Mac OS #248

Merged
merged 3 commits into from
Jul 21, 2024
Merged

ci: revert API 29 test to Mac OS #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aed434
ci: fix test failure on API 26
ashishb Jul 21, 2024
a856f04
ci: switch API 26 and 29 tests back to `macos-latest`
ashishb Jul 21, 2024
953ee31
ci: revert API 29 test to Mac OS
ashishb Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/adbe-unittests-api26.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ jobs:
- name: checkout
uses: actions/checkout@v4

# Ref: https://github.com/ReactiveCircus/android-emulator-runner?tab=readme-ov-file#running-hardware-accelerated-emulators-on-linux-runners
- name: Enable KVM
if: runner.os == 'Linux'
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm

- name: Gradle cache
uses: gradle/gradle-build-action@v3

Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/adbe-unittests-api29.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ concurrency:

jobs:
testOnApi29:
runs-on: ubuntu-latest
# This hangs on ubuntu-latest
# Ref: https://github.com/ashishb/adb-enhanced/pull/239
# Ref: https://github.com/ReactiveCircus/android-emulator-runner/issues/385
runs-on: macos-13 # X86-based as macOS 14 onwards is ARM-based
timeout-minutes: 15

strategy:
Expand All @@ -28,6 +31,7 @@ jobs:

# Ref: https://github.com/ReactiveCircus/android-emulator-runner?tab=readme-ov-file#running-hardware-accelerated-emulators-on-linux-runners
- name: Enable KVM
if: runner.os == 'Linux'
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
Expand All @@ -43,7 +47,7 @@ jobs:
path: |
~/.android/avd/*
~/.android/adb*
key: avd-${{ matrix.api-level }}
key: avd-${{ runner.os }}-${{ matrix.api-level }}

- name: Create AVD and generate snapshot for caching
if: steps.avd-cache.outputs.cache-hit != 'true'
Expand Down
Loading