Check for reserved chunk names

actr/chunk.go

@@ -2,6 +2,9 @@ package actr
 
 import "github.com/asmaloney/gactar/util/container"
 
+// See "Default Chunks" pg. 80 of ACT-R manual.
+var reservedChunkNames = []string{"busy", "clear", "empty", "error", "full", "failure", "free", "requested", "unrequested"}
+
 type Chunk struct {
 	TypeName  string
 	SlotNames []string
@@ -14,6 +17,12 @@ func IsInternalChunkType(name string) bool {
 	return name[0] == '_'
 }
 
+// IsReservedType checks if the slot name is reserved.
+// See "Default Chunks" pg. 80 of ACT-R manual.
+func IsReservedType(name string) bool {
+	return container.Contains(name, reservedChunkNames)
+}
+
 // LookupChunk looks up the chunk (by type name) in the model and returns it (or nil if it does not exist).
 func (model Model) LookupChunk(typeName string) *Chunk {
 	for _, chunk := range model.Chunks {

amod/amod_config_test.go

@@ -104,7 +104,7 @@ func Example_gactarTraceActivationsNonBool() {
 	// ERROR: 'trace_activations' must be 'true' or 'false' (line 5, col 29)
 }
 
-func Example_chunkReservedType() {
+func Example_chunkInternalType() {
 	generateToStdout(`
 	~~ model ~~
 	name: Test
@@ -114,7 +114,20 @@ func Example_chunkReservedType() {
 	~~ productions ~~`)
 
 	// Output:
-	// ERROR: cannot use reserved chunk type '_internal' (chunks beginning with '_' are reserved) (line 5, col 11)
+	// ERROR: cannot use reserved chunk type "_internal" (chunks beginning with '_' are reserved) (line 5, col 11)
+}
+
+func Example_chunkReservedType() {
+	generateToStdout(`
+	~~ model ~~
+	name: Test
+	~~ config ~~
+	chunks { [requested: foo bar] }
+	~~ init ~~
+	~~ productions ~~`)
+
+	// Output:
+	// ERROR: cannot use reserved chunk type "requested" (line 5, col 11)
 }
 
 func Example_chunkDuplicateType() {

amod/validate.go

@@ -19,7 +19,12 @@ type varAndIndex struct {
 // reserved names.
 func validateChunk(model *actr.Model, log *issueLog, chunk *chunkDecl) (err error) {
 	if actr.IsInternalChunkType(chunk.TypeName) {
-		log.errorTR(chunk.Tokens, 1, 2, "cannot use reserved chunk type '%s' (chunks beginning with '_' are reserved)", chunk.TypeName)
+		log.errorTR(chunk.Tokens, 1, 2, "cannot use reserved chunk type %q (chunks beginning with '_' are reserved)", chunk.TypeName)
+		return ErrCompile
+	}
+
+	if actr.IsReservedType(chunk.TypeName) {
+		log.errorTR(chunk.Tokens, 1, 2, "cannot use reserved chunk type %q", chunk.TypeName)
 		return ErrCompile
 	}