Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

[Proposal] LogValues should throw if too many/too few arguments in format string #413

Closed
BrennanConroy opened this issue May 2, 2016 · 0 comments
Assignees
Milestone

Comments

@BrennanConroy
Copy link
Member

Its easy to make a mistake when using Define such as LoggerMessage.Define<string>(x:, y:, formatString: "my string"). This will then throw later if the developer enumerates the values, we should try to throw upon construction.

See issues like aspnet/Mvc#4575 (comment)

@kichalla kichalla self-assigned this May 2, 2016
@kichalla kichalla added this to the 1.0.0-rc2 milestone May 2, 2016
@Eilon Eilon modified the milestones: 1.0.0, 1.0.0-rc2 May 2, 2016
@Eilon Eilon added the 1 - Ready label May 2, 2016
kichalla added a commit that referenced this issue May 2, 2016
[Fixes #413] LogValues should throw if too many/too few arguments in format string
kichalla added a commit that referenced this issue May 2, 2016
[Fixes #413] LogValues should throw if too many/too few arguments in format string
kichalla added a commit that referenced this issue May 2, 2016
[Fixes #413] LogValues should throw if too many/too few arguments in format string
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants