This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
OptionsSnapshot should always be recreated per request #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoK
commented
Jan 31, 2017
| } | ||
| /// <param name="setups">The configuration actions to run.</param> | ||
| public OptionsSnapshot(IEnumerable<IConfigureOptions<TOptions>> setups) : base(setups) | ||
| { } |
There was a problem hiding this comment.
Slight behavior difference with this change, previously we would eager cache .Value in the ctor, now we are lazy and don't cache until the first time .Value is used... We should be intentional with how this works I guess...
There was a problem hiding this comment.
discussed with @divega and we will just have OptionsManager implement both interfaces
HaoK
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
Unblocks using IConfigureOptions which have scoped dependencies like db context
cc @divega @glennc