-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team 1 blog-API #46
base: main
Are you sure you want to change the base?
Team 1 blog-API #46
Conversation
…, icon, search bar, and nav to header
…sync, add manageData()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work , some missing semicolon and nothing important at all. The only important error is the duplicated ID. So we decide to give you 10 points!
|
||
// Get Comments from json server | ||
async function getComments () { | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the finally ?? Bro
try {
try_statements
}
catch (exception_var) {
catch_statements
}
finally {
finally_statements
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All perfect. Good work!
// Variable and listener for searchbar functions | ||
const searchBtn = document.getElementById('headerSearchBtn'); | ||
searchBtn.addEventListener('click', function () { | ||
getSearchResults() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 7 Missing semicolon.
// Call function to define data for window onload | ||
async function manageData () { | ||
const data = await getPostData(); | ||
displayPosts(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 25 Missing semicolon.
@@ -0,0 +1,32 @@ | |||
import { getPostData, displayPosts } from './main.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 1 Missing semicolon.
const posts = await getPostData(); | ||
const searchResults = posts.filter((post) => { | ||
return post.title.includes(searchString); | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 10 Missing semicolon.
} | ||
|
||
|
||
export { getSearchResults, displaySearchResults, removePosts} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 32 Missing semicolon.
index.html
Outdated
<!-- modal content --> | ||
<article id="modalContent" class="modal-dialog modal-dialog-centered"> | ||
<div class="modal-content"> | ||
<header id="modalContent" class="modal-header"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: Duplicate ID modalContent.
From line 35, column 13; to line 35, column 59
<header id="modalContent" class="modal-header">↩
@@ -0,0 +1,72 @@ | |||
@import url('https://fonts.googleapis.com/css2?family=Newsreader:ital,opsz,wght@0,6..72,300;0,6..72,400;0,6..72,500;0,6..72,600;0,6..72,700;0,6..72,800;1,6..72,300;1,6..72,400;1,6..72,500;1,6..72,600;1,6..72,700;1,6..72,800&display=swap'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect Css, congrats!
GREAT JOB!! |
PULL REQUEST