-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog-with-API--JulioMacíasCadera-RogerOlivéDelgado #51
base: main
Are you sure you want to change the base?
Blog-with-API--JulioMacíasCadera-RogerOlivéDelgado #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect job and very clean code!!
<title>Blog with API</title> | ||
</head> | ||
<body> | ||
<main class="main__container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvement suggestion: Apply the principles of writing the attributes in order in HTML tags. https://github.com/necolas/idiomatic-html#attribute-order
postsCont.addEventListener('click', (e) => { | ||
|
||
if (e.target.hasAttribute('data-hide-comments')){ | ||
const postId = e.target.getAttribute('data-show-comments') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 54 and 63 are repeated, maybe you can take it out the if else statement and put it at the beginning of the function.
@@ -0,0 +1,19 @@ | |||
.avatar{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
habeis utilizado nuevas técnicas en el css 👏🏻🥳
@@ -0,0 +1,20 @@ | |||
/*RESET*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,186 @@ | |||
//API url path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.