-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLUTION: Marcel Barreiro & Ricardo Vieira #56
base: main
Are you sure you want to change the base?
Conversation
</div> | ||
</header> | ||
<!-- Page content--> | ||
<div id="container" class="container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many divs
|
||
postsContainer.appendChild(postsRow); | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could have been split into a few js files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a few more comments for a better organization of the code sections
let myModal = document.getElementById("myModal"); | ||
let modalTitle = document.getElementById('modalTitle'); | ||
let modalBody = document.getElementById('modalBody'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordering could be improved
.then((data) => { | ||
getUsers(data); | ||
}) | ||
.catch((error) => console.error(error)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The console logs should be deleted
No description provided.