Fix incorrect rerun-if-changed triggering needless rebuilds #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build.rs has a bug where the build.rs will always be rerun on the second build of the project.
This looks like:
This issue is particularly bad for CI systems that cache a single build of the main branch, and then use that cache for testing incoming PRs, since every build is effectively a second build. This means that even PRs that dont touch the crate have to wait for the crate binary to recompile.
The issue is that a
cargo:rerun-if-changed=
is set for an output file of the build.rs.cargo:rerun-if-changed=
should only be used for inputs, otherwise we will hit issues like this.This PR fixes the issue by removing the problem rerun lines.
This will not regress any functionality since we will still rerun when the
rust/jassets/j4rs*.jar
changes.This additionally let us remove the glob dependency from build.rs since its no longer needed.