-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive in PYI files with ellipsis for PIE796
#8818
Labels
Comments
Agree, this makes sense to fix IMO. |
In a strict statically type-checked context, I feel this might still be undesirable? But that's more for a rule like PyCQA/flake8-pyi#98 |
sciyoshi
added a commit
to sciyoshi/ruff
that referenced
this issue
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I define an enum file with ellipsis in PYI files, the linter complains
in a .PYI files, these values are all set to
...
to denote that they will be populated in other code, and we only care about what the members of the enum are. This is a pretty common idiom so we may want to explicitly whitelist in our check or at least propose a better fix for PYI files as I am unaware of another way of doing this with a placeholder value forEnum
.The text was updated successfully, but these errors were encountered: