Migrate sys.rs generation to stdlibs #11374
Conversation
Signed-off-by: Rahul Modpur <rmodpur2@gmail.com>
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| I001 | 3 | 3 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+3 -0 violations, +0 -0 fixes in 1 projects; 43 projects unchanged)
pypa/cibuildwheel (+3 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ test/test_from_sdist.py:1:1: I001 [*] Import block is un-sorted or un-formatted + test/test_pure_wheel.py:1:1: I001 [*] Import block is un-sorted or un-formatted + test/test_same_wheel.py:1:1: I001 [*] Import block is un-sorted or un-formatted
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| I001 | 3 | 3 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
|
Nice, thank you! The changes in |
| @@ -23,34 +14,19 @@ | |||
| (3, 12), | |||
There was a problem hiding this comment.
stdlibs also supports 3.13 already, btw: https://gist.github.com/thatch/0c7015ef2e0b6c457eb52a558f14beb1
| @@ -61,10 +37,9 @@ class FakeApp: | |||
| "sre", | |||
There was a problem hiding this comment.
These hardcoded ones should probably be removed and change to modules = {} -- we haven't had sre since 2.7. I suspect these were added to work around bugs in the sphinx inventory?
| if root not in ["__future__", "__main__"]: | ||
| modules.add(root) | ||
| for module in stdlib_module_names(f"{major_version}.{minor_version}"): | ||
| if module not in ["__future__", "__main__"]: |
There was a problem hiding this comment.
I don't think __main__ would ever be reported as stdlib.
|
re |
|
I think that's the right call @thatch. |
Summary
Closes #11347