Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict fowarding newline argument in open() calls to Python versions >= 3.10 #12244

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Restrict fowarding newline argument in open() calls to Python versions >= 3.10 #12244

merged 3 commits into from
Jul 9, 2024

Conversation

evanrittenhouse
Copy link
Contributor

Summary

Fixes #12222

Test Plan

@evanrittenhouse evanrittenhouse marked this pull request as draft July 8, 2024 14:31
@evanrittenhouse evanrittenhouse marked this pull request as ready for review July 8, 2024 14:33
charliermarsh
charliermarsh approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) July 9, 2024 02:37
@charliermarsh charliermarsh merged commit 1e04bd0 into astral-sh:main Jul 9, 2024
20 checks passed
@evanrittenhouse evanrittenhouse deleted the evanrittenhouse/12223 branch July 9, 2024 15:40
@BrewTestBot BrewTestBot mentioned this pull request Jul 15, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FURB103 false positive for python <3.10
2 participants
@evanrittenhouse @charliermarsh