Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Add support for editable installs to the module resolver #12307

Merged
merged 19 commits into from
Jul 16, 2024
Merged

[red-knot] Add support for editable installs to the module resolver #12307

merged 19 commits into from
Jul 16, 2024

Commits on Jul 12, 2024

  1. [red-knot] Add support for editable installs to the module resolver

    @AlexWaygood
    AlexWaygood committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    287fcec View commit details
    Browse the repository at this point in the history

  2. Deduplicate search path roots

    @AlexWaygood
    AlexWaygood committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    645532b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Make all module resolution search paths absolute

    @AlexWaygood
    AlexWaygood committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    a456ef9 View commit details
    Browse the repository at this point in the history

  2. Improve docs

    @AlexWaygood
    AlexWaygood committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    9d68c07 View commit details
    Browse the repository at this point in the history

  3. Be more lenient about trailing and leading whitespace

    @AlexWaygood
    AlexWaygood committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    99d87b4 View commit details
    Browse the repository at this point in the history

  4. Make it a Salsa query and add caching tests

    @AlexWaygood
    AlexWaygood committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    f7219f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Lazily discover editable installations

    @AlexWaygood
    AlexWaygood committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    f664391 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Misc review comments

    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    42551d1 View commit details
    Browse the repository at this point in the history

  2. Simplify

    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1709e91 View commit details
    Browse the repository at this point in the history

  3. Use report_untracked_read()

    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    64f03c6 View commit details
    Browse the repository at this point in the history

  4. Avoid an unnecessary allocation

    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b1b2ffb View commit details
    Browse the repository at this point in the history

  5. Don't add a new method for creating arbitrary directories in tests

    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1adf37d View commit details
    Browse the repository at this point in the history

  6. Change test so that it asserts the cache is invalidated after modific… 

    …ation rather than deletion of the `pth` file
    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    388fdca View commit details
    Browse the repository at this point in the history

  7. Update crates/red_knot_module_resolver/src/resolver.rs 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @AlexWaygood @MichaReiser
    AlexWaygood and MichaReiser committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1c267b5 View commit details
    Browse the repository at this point in the history

  8. Cleanup tests

    @AlexWaygood
    AlexWaygood committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6d8acb9 View commit details
    Browse the repository at this point in the history

  9. Fix comment 

    Co-authored-by: Carl Meyer <carl@astral.sh>
    @AlexWaygood @carljm
    AlexWaygood and carljm committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e29d3d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Fix bugs, address review, add TODOs

    @AlexWaygood
    AlexWaygood committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    23d2d8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'editables' of https://github.com/astral-sh/ruff into ed… 

    …itables
    @AlexWaygood
    AlexWaygood committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    52f457b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into editables

    @AlexWaygood
    AlexWaygood committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0d64399 View commit details
    Browse the repository at this point in the history