Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruff] Implement incorrectly-parenthesized-tuple-in-subscript (RUF031) #12480

Merged
merged 35 commits into from
Aug 7, 2024
Merged

[ruff] Implement incorrectly-parenthesized-tuple-in-subscript (RUF031) #12480

merged 35 commits into from
Aug 7, 2024

Commits on Aug 7, 2024

  1. add test fixture for lint rule

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8acd409 View commit details
    Browse the repository at this point in the history

  2. add test cases with newlines

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e9aa21c View commit details
    Browse the repository at this point in the history

  3. add module to check for parens around tuples in getitem calls

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d59408f View commit details
    Browse the repository at this point in the history

  4. add to codes as RUF031

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7882fcd View commit details
    Browse the repository at this point in the history

  5. add pointer to test case for rule

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    be86fe9 View commit details
    Browse the repository at this point in the history

  6. implement rule for subscript expressions in checker

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    55c334a View commit details
    Browse the repository at this point in the history

  7. update schema

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ec086e8 View commit details
    Browse the repository at this point in the history

  8. add snapshot for RUF031

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    284a194 View commit details
    Browse the repository at this point in the history

  9. reformat example

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9513c9c View commit details
    Browse the repository at this point in the history

  10. begin adding settings functionality to ruff ruleset

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5b0a92a View commit details
    Browse the repository at this point in the history

  11. rename rule and add config for ruff

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    61106a6 View commit details
    Browse the repository at this point in the history

  12. update rule fix and violation logic to respect configuration

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f3db34e View commit details
    Browse the repository at this point in the history

  13. update snapshot

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3f5d5bb View commit details
    Browse the repository at this point in the history

  14. update schema

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a0e7b04 View commit details
    Browse the repository at this point in the history

  15. fix ruff settings namespace copypasta mistake and regenerate snapshot

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0c339ab View commit details
    Browse the repository at this point in the history

  16. add test case with parens on setting

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c2e350b View commit details
    Browse the repository at this point in the history

  17. make ruff an option group

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5e1e0a4 View commit details
    Browse the repository at this point in the history

  18. rename rule to satisfy convention

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a696961 View commit details
    Browse the repository at this point in the history

  19. change rule and config option names

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    209add0 View commit details
    Browse the repository at this point in the history

  20. typo 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @dylwil3 @MichaReiser @AlexWaygood
    2 people authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    bf5947d View commit details
    Browse the repository at this point in the history

  21. Use let .. else 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @dylwil3 @MichaReiser @AlexWaygood
    2 people authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2a895b6 View commit details
    Browse the repository at this point in the history

  22. resolve comments

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dedda82 View commit details
    Browse the repository at this point in the history

  23. update snapshot

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d8ea3a2 View commit details
    Browse the repository at this point in the history

  24. treat single element tuples as well

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f7ff6a3 View commit details
    Browse the repository at this point in the history

  25. update snapshot

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dd3d881 View commit details
    Browse the repository at this point in the history

  26. clippy

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    cec2241 View commit details
    Browse the repository at this point in the history

  27. typo and subscript instead of getitem

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    96fcb28 View commit details
    Browse the repository at this point in the history

  28. update snapshot again

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    bbe1801 View commit details
    Browse the repository at this point in the history

  29. change name of setting

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5a83811 View commit details
    Browse the repository at this point in the history

  30. update schema

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4cc9eb5 View commit details
    Browse the repository at this point in the history

  31. update docstrings

    @dylwil3 @AlexWaygood
    dylwil3 authored and AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    767ae99 View commit details
    Browse the repository at this point in the history

  32. rename module and remove clippy allow

    @dylwil3
    dylwil3 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b95f068 View commit details
    Browse the repository at this point in the history

  33. match to if/else

    @dylwil3
    dylwil3 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    84afc6e View commit details
    Browse the repository at this point in the history

  34. Apply suggestions from code review

    @AlexWaygood
    AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ccf47a7 View commit details
    Browse the repository at this point in the history

  35. final nits

    @AlexWaygood
    AlexWaygood committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4ba055d View commit details
    Browse the repository at this point in the history