Eagerly validate search paths #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
eagerly-validate-search-paths
branch
from
f751f13
to
54b5f0b
Compare
|
An error occurred while trying to automatically change base from
warn-about-skipped-pth-files
to
main
August 9, 2024 14:29
MichaReiser
force-pushed
the
eagerly-validate-search-paths
branch
from
60568d5
to
099162a
Compare
MichaReiser
commented
Aug 9, 2024
| let search_path = SearchPath::extra(system, path)?; | ||
| files.try_add_root( | ||
| db.upcast(), | ||
| search_path.as_system_path().unwrap(), |
There was a problem hiding this comment.
I haven't forgotten about the unwrap. I addressed it in the following PR. I think this PR even added a few more as_system_path().unwrap() calls.
AlexWaygood
approved these changes
Aug 9, 2024
crates/red_knot_python_semantic/src/module_resolver/resolver.rs
Outdated
Show resolved
Hide resolved
MichaReiser
force-pushed
the
eagerly-validate-search-paths
branch
from
099162a
to
7b9da87
Compare
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves from a lazy search path validation and makes it eagerly so that Red Knot fails to start if the settings are incorrect.
The main change is that this PR removes
ModuleResolutionSettingsand instead stores the "resolved"SearchPathsdirectly onProgram. Program gets a newProgram::from_settings(db, settings)function that returns an error if any setting has an invalid value.Test Plan
cargo test