Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that BLE001 supports both BaseException and Exception #12788

Conversation

rhoban13
Copy link
Contributor

@rhoban13 rhoban13 commented Aug 9, 2024

Summary

Document that flake8-blind-except supports Exception as well as BaseException.

Test Plan

Locally ran mkdocs.

@rhoban13 rhoban13 force-pushed the document_blind_except_supports_Exception branch from 52eca17 to ee59439 Compare August 9, 2024 14:44
@rhoban13
Copy link
Contributor Author

rhoban13 commented Aug 9, 2024

Motivated by my confusion in #970 (comment)

Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #12788 will improve performances by 4.15%

Comparing rhoban13:document_blind_except_supports_Exception (ee59439) with main (a176679)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main rhoban13:document_blind_except_supports_Exception Change
linter/default-rules[pydantic/types.py] 1.9 ms 1.8 ms +4.15%

Copy link
Contributor

github-actions bot commented Aug 9, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Aug 9, 2024
@MichaReiser MichaReiser merged commit 253474b into astral-sh:main Aug 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants