Remove red_knot_python_semantic::python_version::TargetVersion
#12790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexWaygood
force-pushed
the
alex/remove-target-version
branch
from
7c18f95
to
a7f64be
Compare
MichaReiser
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a followup to @MichaReiser's comment at #12782 (comment):
Instead of having two types in
ruff_python_semantic-- one that represents an arbitrary Python version, and another that represents the fixed set of versions that we know we support -- this PR consolidates it so that we only use a single type (the more general one). The only case where we need a fixed enumeration of versions that we actually support (at least currently) is in a CLI argparsing context -- but the CLI crates already have their own enums.This will have quite a few merge conflicts with #12786... I'm okay with waiting until @MichaReiser's stack of module-resolver validation PRs has landed before merging this. It's not urgent.
cargo test