Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid no-self-use for attrs-style validators #13166

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Avoid no-self-use for attrs-style validators #13166

merged 1 commit into from
Aug 30, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #12568.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Aug 30, 2024
@charliermarsh charliermarsh merged commit a73bebc into main Aug 30, 2024
20 checks passed
@charliermarsh charliermarsh deleted the charlie/conflict branch August 30, 2024 16:39
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 53 projects unchanged)

apache/airflow (+0 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- airflow/decorators/task_group.py:71:9: PLR6301 Method `_validate` could be a function, class method, or static method

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PLR6301 1 0 1 0 0

@charliermarsh
Copy link
Member Author

Ecosystem change is correct!

@BrewTestBot BrewTestBot mentioned this pull request Sep 5, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PLR6301 not aware of attrs validation decorator
1 participant
@charliermarsh