Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rust 1.81 #13265

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Upgrade to Rust 1.81 #13265

merged 1 commit into from
Sep 6, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Sep 6, 2024

Summary

Upgrades to Rust 1.81.

I'm a bit worried about the change that an incorrect Ord implementation now panics when sorting instead of resulting in a messed-up sorting. We discovered at least one such bug thanks to fuzzing.

Test Plan

cargo test

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Sep 6, 2024
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #13265 will degrade performances by 5.13%

Comparing micha/rust-1.81 (e74aea7) with main (a4ebe7d)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main micha/rust-1.81 Change
linter/default-rules[pydantic/types.py] 1.8 ms 1.9 ms -5.13%

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about the change that an incorrect Ord implementation now panics when sorting instead of resulting in a messed-up sorting. We discovered at least one such bug thanks to fuzzing.

Curious to know which bug is this, not sure I see any changes in this PR that's relevant.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser
Copy link
Member Author

It's #12471

@MichaReiser MichaReiser merged commit c3bcd5c into main Sep 6, 2024
19 of 20 checks passed
@MichaReiser MichaReiser deleted the micha/rust-1.81 branch September 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants