[red-knot] Handle StringLiteral truncation #13276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylwil3
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
|
carljm
approved these changes
Sep 7, 2024
Comment on lines
2056
to
2061
| ( | ||
| Type::StringLiteral(_) | Type::LiteralString, | ||
| Type::LiteralString, | ||
| ast::Operator::Add, | ||
| ) | ||
| | (Type::LiteralString, Type::StringLiteral(_), ast::Operator::Add) => { |
There was a problem hiding this comment.
Given that match arms are checked in order, and we already handled (StringLiteral, StringLiteral, Add) above, can we simplify this pattern to ((StringLiteral | LiteralString), (StringLiteral | LiteralString), Add)?
There was a problem hiding this comment.
Good idea! I guess if someone changed around the order one of the unit tests would fail, so this seems pretty safe.
Done!
CodSpeed Performance ReportMerging #13276 will improve performances by 8.54%Comparing Summary
Benchmarks breakdown
|
carljm
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type of the form
Literal["..."]would be constructed with too large of a string, this PR converts it toLiteralStringinstead.We also extend inference for binary operations to include the case where one of the operands is
LiteralString.Closes #13224