Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parser goal 'All' to 'all' #6867

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Rename parser goal 'All' to 'all' #6867

merged 2 commits into from
Aug 25, 2023

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Aug 25, 2023

Summary

Rename the Goal All to all for consistency

Test Plan

cargo test

@MichaReiser
Copy link
Member Author

MichaReiser commented Aug 25, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser changed the title Parser: 'All' -> 'all', remove unused rule Rename parser goal 'All' to 'all' Aug 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      4.1±0.02ms    10.0 MB/sec    1.00      4.0±0.03ms    10.1 MB/sec
formatter/numpy/ctypeslib.py               1.02    854.6±2.30µs    19.5 MB/sec    1.00    839.7±2.50µs    19.8 MB/sec
formatter/numpy/globals.py                 1.06     84.1±0.37µs    35.1 MB/sec    1.00     79.2±0.36µs    37.2 MB/sec
formatter/pydantic/types.py                1.02  1681.1±25.81µs    15.2 MB/sec    1.00   1643.5±3.55µs    15.5 MB/sec
linter/all-rules/large/dataset.py          1.00     10.1±0.06ms     4.0 MB/sec    1.01     10.2±0.07ms     4.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.7±0.01ms     6.2 MB/sec    1.01      2.7±0.01ms     6.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    377.4±1.22µs     7.8 MB/sec    1.01    381.9±0.46µs     7.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.2±0.05ms     4.9 MB/sec    1.02      5.3±0.02ms     4.8 MB/sec
linter/default-rules/large/dataset.py      1.00      5.3±0.02ms     7.7 MB/sec    1.02      5.4±0.02ms     7.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1188.0±4.15µs    14.0 MB/sec    1.00   1188.6±3.32µs    14.0 MB/sec
linter/default-rules/numpy/globals.py      1.02    140.1±6.07µs    21.1 MB/sec    1.00    137.2±0.50µs    21.5 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.4±0.02ms    10.6 MB/sec    1.00      2.4±0.01ms    10.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      5.3±0.19ms     7.6 MB/sec    1.00      5.3±0.68ms     7.6 MB/sec
formatter/numpy/ctypeslib.py               1.02  1085.7±71.78µs    15.3 MB/sec    1.00  1068.2±64.24µs    15.6 MB/sec
formatter/numpy/globals.py                 1.00     98.6±5.24µs    29.9 MB/sec    1.04    102.3±9.40µs    28.8 MB/sec
formatter/pydantic/types.py                1.00      2.1±0.11ms    12.2 MB/sec    1.03      2.1±0.11ms    11.9 MB/sec
linter/all-rules/large/dataset.py          1.05     15.2±2.12ms     2.7 MB/sec    1.00     14.5±0.49ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.17ms     4.0 MB/sec    1.01      4.2±0.25ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.01   529.2±24.83µs     5.6 MB/sec    1.00   525.8±32.31µs     5.6 MB/sec
linter/all-rules/pydantic/types.py         1.03      7.9±0.29ms     3.2 MB/sec    1.00      7.6±0.28ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.00      8.2±0.35ms     4.9 MB/sec    1.00      8.2±0.29ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1736.1±82.90µs     9.6 MB/sec    1.00  1737.9±69.29µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.00   214.2±11.33µs    13.8 MB/sec    1.05   225.1±47.57µs    13.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.14ms     7.1 MB/sec    1.01      3.7±0.17ms     7.0 MB/sec

@MichaReiser MichaReiser enabled auto-merge (squash) August 25, 2023 11:53
@MichaReiser MichaReiser merged commit 15b7525 into main Aug 25, 2023
15 checks passed
@MichaReiser MichaReiser deleted the parser-cleanup branch August 25, 2023 12:00
@zanieb
Copy link
Member

zanieb commented Aug 25, 2023

I'm impressed you succeeded in changing this at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Related to the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants