Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playground README.md #6909

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Update playground README.md #6909

merged 1 commit into from
Aug 27, 2023

Conversation

cnpryer
Copy link
Contributor

@cnpryer cnpryer commented Aug 27, 2023

This PR makes a few small changes to the playground's README.md.

  1. I needed to install wasm-pack -- which wasn't mentioned in the README.md.
  2. The same command is mentioned for both release and debug builds (npm run build:wasm). Maybe I'm misunderstanding this, but I changed the debug command to npm run dev:wasm.
  3. Some wording to tie the changes together.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2023

CodSpeed Performance Report

Merging #6909 will not alter performance

Comparing cnpryer:playground (ed1e586) with main (eae59cf)

Summary

✅ 16 untouched benchmarks

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichaReiser MichaReiser merged commit f33277a into astral-sh:main Aug 27, 2023
16 checks passed
@MichaReiser MichaReiser added documentation Improvements or additions to documentation playground A playground-specific issue labels Aug 27, 2023
@cnpryer cnpryer deleted the playground branch August 27, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation playground A playground-specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants