This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Changes inspired by whitespace package #1546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -452,6 +453,14 @@ class Editor extends Model | |||
| @insertNewline() | |||
| @moveCursorUp() if onFirstLine | |||
|
|
|||
| # {Delegates to: TextBuffer.append} | |||
| appendText: (text, normalizeLineEndings) -> | |||
There was a problem hiding this comment.
Having this on Editor feels weird to me, since insertText uses selections and this does not. To me Editor methods are all about operating on selections/cursors. And this method plus deleteBufferRow deviate from that conceptual model.
There was a problem hiding this comment.
We can go that route and remove all non-selection/cursor based methods from editor. But
I think it is more of an internal implementation difference than practical difference for package authors.
It comes down to: Do we want package authors to think about whether they need to call a method on an Editor or an Editor's Buffer? Or do we just want to point them towards the Editor's API.
This was referenced Mar 7, 2024
This was referenced Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.