Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Taffy-branded logo #428

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use Taffy-branded logo #428

wants to merge 2 commits into from

Conversation

JamoCA
Copy link
Contributor

@JamoCA JamoCA commented Mar 31, 2022

Use transparent PNG (using data URI) for favicon & H1 header on dashboard.

@JamoCA
Add embedded PNG favicon
03b9569 
Remove 3rd party dependence (fav.farm) and use embedded PNG.
@JamoCA
Add inline Taffy PNG logo to H1 header
c14b5e7 
I added a non-repeatable background image to the H1 header. (I don't use LESS, so I'm not sure what to do there.)
@netlify
Copy link

netlify bot commented Mar 31, 2022 •
edited
Loading

✅ Deploy Preview for taffy-docs canceled.

Name Link
🔨 Latest commit c14b5e7
🔍 Latest deploy log https://app.netlify.com/sites/taffy-docs/deploys/62450c2a3f0e7a000882862b

@JamoCA JamoCA mentioned this pull request Mar 31, 2022
Open
@atuttle
Copy link
Owner

atuttle commented Apr 13, 2022

Rather than embed it as a data-image twice, why not create a file and link to that?

@JamoCA
Copy link
Contributor Author

JamoCA commented Apr 19, 2022

The data URIs are actually different. I used a smaller favicon generated by RealFavIconGenerator [https://realfavicongenerator.net/] and think I used an SVG for the logo.

I reviewed the main source and noticed that two (2) CSS files were included using cfinclude (rather than using a regular HTML link tag). I also noticed that the none of the CFM/CFC files used img tags. While there is a logo-lg.png file, it is only used for the readme.md file, isn't a square image and wasn't used anywhere else. I'm not sure why this was done, but thought it could be due to path issues and I didn't want to create any problems.

I can generate both static resource files if you'd prefer to use them instead. (I cropped the readme logo and submitted it to RealFaviconGenerator.)

@atuttle
Copy link
Owner

atuttle commented Apr 27, 2022

Yes, please. Let's use static files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamoCA @atuttle