Feat: Refactore IsPrecompileResult type #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
changed the title
mrLSD
changed the title
mrLSD
changed the title
mrLSD
added
enhancement
aleksuss
reviewed
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
➡️ Refactored
IsPrecompileResulttype.➡️ Refactored
is_cold- return result without errorMotivation
Due to the fact that
EVM Precompilescannot contain additional information about gas calculation for a warm address, there is no need for redundant fields in theIsPrecompileResulttype. This situation is unreachable.As a result, this allows us to completely eliminate error returns in the
is_coldfunction, since it cannot return an error. Currently, there are noPrecompilesthat support warm address logic in their functionality and, at the same time, charge additional gas.Thus, it is possible to simplify the
IsPrecompileResulttype without any issues, while making theis_coldmechanism non-error-returning.Important note: The
IsPrecompileResultresult is only used for theis_coldfunction.