Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to mention support for Angular versions #738

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Oct 3, 2022

Changes

With #735 , we will no longer have support for Angular < 12. As Angular no longer supports Angular < 12 themselves, this should be fine.

As the readme is very outdated, this PR updates it to better reflect todays support based on the supported versions by Angular.

It also removes the explicit mention about breaking changes in v5, as v5 has been around for over two years now.

Checklist

@frederikprijck frederikprijck marked this pull request as ready for review October 3, 2022 12:42
@frederikprijck frederikprijck requested a review from a team as a code owner October 3, 2022 12:42
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 85.71% // Head: 85.71% // No change to project coverage 👍

Coverage data is based on head (8ba3711) compared to base (a1f57f9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           2        2           
  Lines           7        7           
=======================================
  Hits            6        6           
  Misses          1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frederikprijck frederikprijck merged commit 30c0802 into main Oct 3, 2022
@frederikprijck frederikprijck deleted the chore/readme-ng-support branch October 3, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants