Allow GET requests in specs #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not something anyone should do in production. But in tests, this allows us to bypass CSRF.
This was referenced Jan 14, 2021
Closed
|
merged in #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is not something anyone should do in production. But in tests, this
allows us to bypass CSRF.
Following CVE-2015-9284, omniauth now has GET requests disabled by default.
While this is a good behavior in real environments, it's makes things a bit harder in tests, as we'd have to generate a valid CSRF token.
This change allows bypassing it (and running tests on the latest omniauth) by allowing GET requests and keep using them.
References
See Omniauth CVE: https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284
Testing
This change changes only the unit tests, not actual behavior.
Checklist