JS Bindings: Enhance binding macros to support different kinds of functions #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions that deal with raw pointers.
frericp
commented
May 12, 2021
| @@ -13,256 +13,338 @@ std::vector<myClass> arrayToVec(myClass *arr, int size) | |||
|
|
|||
| // Binding helpers | |||
There was a problem hiding this comment.
The simple BIND_FUNC_X_Y macros haven't been changed, just renamed. So most of the changes in this file can be ignored. Only the macros that carry out the actual work (formerly BIND_FUNC_X, now BIND_X) have been modified. Furthermore, new macros for static and global functions have been introduced, together with their _RAW_PTR version.
bernardkwok
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for static class functions, global utility functions, and functions that deal with raw pointers.
The current
BIND_FUNCmacro has been renamed toBIND_MEMBER_FUNC.FYI @muenstc @sdunkel @kohakukun
Update: #1184