Full JS bindings for MaterialX Core #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Substitute some instances of optional_override by select_overload - Use ems::Constants for exposing Constants
sdunkel
commented
May 17, 2021
frericp
reviewed
May 17, 2021
|
How did you organize the bindings so far, regarding their order? Are they defined in the same order as in the C++ headers? |
sdunkel
commented
May 17, 2021
|
Yes, we try to have the same order in cpp and js binding to make it easier to compare both |
frericp
reviewed
May 17, 2021
muenstc
reviewed
May 17, 2021
…incorrect use of BIND_MEMBER_FUNC_RAW_PTR, remove newlines
frericp
reviewed
May 21, 2021
bernardkwok
approved these changes
May 25, 2021
| @@ -1,13 +1,16 @@ | |||
|
|
|||
| #include "../vectorHelper.h" | |||
There was a problem hiding this comment.
Nitpick: To prep for merging we should stick with an CamelCase.h naming convention for file names for both of these.
| #include <MaterialXCore/Geom.h> | ||
|
|
||
| #include <emscripten.h> | ||
| #include <emscripten/bind.h> | ||
|
|
||
| namespace ems = emscripten; | ||
| namespace mx = MaterialX; | ||
|
|
||
| #define BIND_GEOMINFO_FUNC_INSTANCE(NAME, T) \ |
There was a problem hiding this comment.
As a note. "#define" aren't really used for the library and "using" is used instead. I'm not sure if it applies to hear bit a merge head-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the set of bindings for the MaterialXCore package. Additional tests will follow.
Update: #1184