Enable mipmap generation for JsMaterialXView #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohakukun
reviewed
Jun 23, 2021
kohakukun
approved these changes
Jun 23, 2021
muenstc
added a commit
that referenced
this pull request
Jul 1, 2021
…w) (#1244) * Rough GLES generator setup. * Fix incorrect target inheritance. * fixed copying of library folder * initial materialx web viewer implementation with dummy shader (#1207) * Adapt ESSLShaderGenerator for WebGL2 (#1211) * Minimize required code changes between Glsl and Essl shadergen by exposing more `emit` functions * Get correct vertex prefix for Essl in the node implementations. * Update three js sample to render standard_surface_default material Co-authored-by: dunkels <sebastian.dunkel@autodesk.com> Co-authored-by: kohakukun <aura.munoz@autodesk.com> * fix: Cleanup essl context for new documents (#1226) Co-authored-by: kohakukun <aura.munoz@autodesk.com> * fix: Add explicit casting for switch statement (#1227) Co-authored-by: kohakukun <aura.munoz@autodesk.com> * clean up, add entry for Essl shader generation option to Viewer.md (#1228) * fix: stdlib explicit cast for essl compatibility (#1229) * add precission to vertex shader * fix: Add explicit cast for ess compatibility * address comments * quick fix Co-authored-by: kohakukun <aura.munoz@autodesk.com> * Enable mipmap generation for JsMaterialXView (#1242) * Throw if EsslShaderGenerator has access to a resource binding context (#1230) * clean up (#1247) * clean up pass 2 Co-authored-by: bernardkwok <bernard.kwok@autodesk.com> Co-authored-by: dunkels <sebastian.dunkel@autodesk.com> Co-authored-by: Sebastian Dunkel <sdunkel@users.noreply.github.com> Co-authored-by: kohakukun <aura.munoz@autodesk.com> Co-authored-by: Aura Munoz <paraprogramar@gmail.com>
ashwinbhat
pushed a commit
that referenced
this pull request
Feb 25, 2023
This changelist switches from GLFW to ImGui key constants in the editor, removing the need to include GLFW headers for input handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.