JsBindings: Add support for writing documents to files #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frericp
requested review from
ashwinbhat,
kohakukun,
sdunkel,
bernardkwok and
muenstc
frericp
force-pushed
the
adsk_contrib/xml_writing
branch
from
259b5e0
to
05efdb8
Compare
frericp
force-pushed
the
adsk_contrib/xml_writing
branch
from
05efdb8
to
ee8ae63
Compare
kohakukun
reviewed
Jul 8, 2021
| @@ -451,5 +466,47 @@ | |||
| return _readFromXmlString(doc, result.data, searchPath, readOptions, filesLoaded, result.filePath); | |||
| }); | |||
| }; | |||
|
|
|||
| // Write a document to a file. | |||
| Module.writeToXmlFile = function(doc, fileName, writeOptions = null) { | |||
There was a problem hiding this comment.
This two functions are exactly the same except a word, can we rewrite it?
Maybe one function for checking the arguments
| // Export inlining included content | ||
| const exportOptions = new mx.XmlExportOptions(); | ||
| exportOptions.writeXIncludeEnable = false; | ||
| mx.writeToXmlFile(doc, filename, exportOptions); |
There was a problem hiding this comment.
shouldn't it be exportToXmlFile?
|
|
||
| // Node only, because we cannot read from a downloaded file in the browser | ||
| it('Write XML to file', async () => { | ||
| const filename = '_build/testFile.mtlx'; |
There was a problem hiding this comment.
This tests are exactly the same? why not run a loop or something? Maybe we dont need XmlExport.spec?
There was a problem hiding this comment.
I actually just copied the test because I was too lazy to write a more specific one for it 😅
Replaced it with one that actually checks the specifics of the export function 👍
kohakukun
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables writing documents to files. In the browser, the file will be downloaded automatically.
Update #1184