Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virsh_domif_setlink_getlink:Remove driver settings from iface when model is not virtio #5892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

virsh_domif_setlink_getlink:Remove driver settings from iface when model is not virtio #5892

wants to merge 1 commit into from

Conversation

chloerh
Copy link
Contributor

@chloerh chloerh commented Sep 10, 2024

'driver' is only supported by virtio

Depends on:

Test result:

(01/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.e1000e.interface_net.no_config.domain_name.running_guest.domif_setlink.setlink_down: PASS (82.74 s)
 (02/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.e1000e.interface_net.no_config.domain_name.running_guest.domif_setlink.stable_test.setlink_down.restart_libvirtd: PASS (193.15 s)
 (03/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.e1000e.interface_mac.no_config.domain_name.running_guest.domif_setlink.setlink_down: PASS (72.76 s)
 (04/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.e1000e.interface_mac.no_config.domain_name.running_guest.domif_setlink.stable_test.setlink_up.save_restore: PASS (82.62 s)
 (05/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.e1000e.interface_mac.no_config.domain_name.running_guest.domif_setlink.stable_test.setlink_down.save_restore:PAASS (184.97 s)
 (06/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.rtl8139.interface_net.no_config.domain_name.running_guest.domif_setlink.setlink_down: PASS (80.13 s)
 (07/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.rtl8139.interface_net.no_config.domain_name.running_guest.domif_setlink.stable_test.setlink_down.restart_libvirtd: PASS (190.98 s)
 (08/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.rtl8139.interface_mac.no_config.domain_name.running_guest.domif_setlink.setlink_down: PASS (78.10 s)
 (09/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.rtl8139.interface_mac.no_config.domain_name.running_guest.domif_setlink.stable_test.setlink_up.save_restore: PASS (84.44 s)
 (10/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.positive_test.rtl8139.interface_mac.no_config.domain_name.running_guest.domif_setlink.stable_test.setlink_down.save_restore:PASS (185.93 s)
 (11/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.multi_functional_test.e1000e.check_update_device: PASS (90.11 s)
 (12/12) type_specific.io-github-autotest-libvirt.virsh.domif_setlink_getlink.multi_functional_test.rtl8139.check_update_device: PASS (87.60 s)
RESULTS    : PASS 12 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@chloerh
virsh_domif_setlink_getlink:Remove driver settings from iface when mo…
14c7dd7 
…del is not virtio

'driver' is only supported by virtio

Signed-off-by: Haijiao Zhao <haizhao@redhat.com>
yanqzhan
yanqzhan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@yanqzhan yanqzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Yingshun Yingshun added the depend on The PR has dependency on other PRs label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanqzhan yanqzhan yanqzhan approved these changes

@Yingshun Yingshun Yingshun approved these changes

Assignees
No one assigned
Labels
depend on The PR has dependency on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chloerh @yanqzhan @Yingshun