iface-hoplug: Change login method for network interface verification

[misanjumn]

Change login method for network interface verification

1. Use wait_for_login(serial=True) method to login into the guest through ssh first and then try serial login if failed.
2. Using vm.wait_for_serial_login(username, password) as the primary method is leading to Login Timeout Issues.
3. In order to check if network iface exists, using the wait_for_login method is faster and successful. If failed, serial=True will result in fallback to serial login.

Signed-off-by: Misbah Anjum N misanjum@linux.vnet.ibm.com

[misanjumn]

Before the patch

 (0737/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.default.active:  FAIL: Can't see interface in current state in vm (283.20 s)
 (0739/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.persistent.active:  FAIL: Can't see interface in current state in vm (284.21 s)
 (0741/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current.active:  FAIL: Can't see interface in current state in vm (282.76 s)
 (0743/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live.active:  FAIL: Can't see interface in current state in vm (289.47 s)
 (0747/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_config.active:  FAIL: Can't see interface in current state in vm (285.62 s)
 (0751/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_persistent.active:  FAIL: Can't see interface in current state in vm (284.14 s)
 (0757/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.config_persistent.active:  FAIL: Can't see interface in current state in vm (289.15 s)
 (0759/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_config_persistent.active:  FAIL: Can't see interface in current state in vm (287.09 s)
 (0761/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.check_mac.active:  FAIL: Can't see interface in current state in vm (306.59 s)
 (0776/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_e1000e.rom_enable_yes:  FAIL: Failed to attach-interface: error: Failed to attach device from /var/tmp/xml_utils_temp_udtz_1l7.xml\nerror: internal error: unable to execute QEMU command 'device_add': failed to find romfile "/usr/share/ipxe/1af41000.rom" (32.73 s)
 (0793/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.default.active:  FAIL: Can't see interface in current state in vm (285.66 s)
 (0795/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.persistent.active:  FAIL: Can't see interface in current state in vm (282.37 s)
 (0797/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.current.active:  FAIL: Can't see interface in current state in vm (281.60 s)
 (0799/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.live.active:  FAIL: Can't see interface in current state in vm (282.74 s)
 (0803/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.live_config.active:  FAIL: Can't see interface in current state in vm (286.98 s)
 (0807/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.live_persistent.active:  FAIL: Can't see interface in current state in vm (285.45 s)
 (0813/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.config_persistent.active:  FAIL: Can't see interface in current state in vm (282.99 s)
 (0815/2986) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_iface.iface_attach.model_virtio.options_test.live_config_persistent.active:  FAIL: Can't see interface in current state in vm (287.38 s)

After the patch

 (02/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.default.active:  PASS (233.27 s)
 (03/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.default.inactive:  PASS (104.88 s)
 (04/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.persistent.active:  PASS (214.59 s)
 (05/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.persistent.inactive:  PASS (107.73 s)
 (06/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current.active:  PASS (235.09 s)
 (07/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current.inactive:  PASS (107.38 s)
 (08/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live.active:  PASS (234.10 s)
 (09/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live.inactive:  PASS (105.23 s)
 (10/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.config.active:  PASS (538.42 s)
 (11/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.config.inactive:  PASS (108.82 s)
 (12/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_config.active:  PASS (216.29 s)
 (13/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_config.inactive:  PASS (106.25 s)
 (14/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current_cofig.active:  PASS (108.20 s)
 (15/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current_cofig.inactive:  PASS (105.71 s)
 (16/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_persistent.active:  PASS (217.32 s)
 (17/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_persistent.inactive:  PASS (105.92 s)
 (18/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_current.active:  PASS (107.56 s)
 (19/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_current.inactive:  PASS (106.39 s)
 (20/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current_persistent.active:  PASS (107.88 s)
 (21/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.current_persistent.inactive:  PASS (106.44 s)
 (22/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.config_persistent.active:  PASS (215.28 s)
 (23/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.config_persistent.inactive:  PASS (108.12 s)
 (24/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_config_persistent.active:  PASS (216.59 s)
 (25/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.live_config_persistent.inactive:  PASS (105.29 s)
 (26/26) type_specific.io-github-autotest-libvirt.virtual_network.iface_hotplug.at_device.iface_attach.model_virtio.options_test.check_mac.active:  PASS (235.90 s)