Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPU:add stream installation way for leapp tool #4113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IPU:add stream installation way for leapp tool #4113

wants to merge 1 commit into from
+4 −1

Conversation

MiriamDeng
Copy link
Contributor

ID:2634

Provide installing particular packages for leapp tool

@MiriamDeng
Copy link
Contributor Author

@PaulYuuu @fbq815 could you please to review this patch ?

PaulYuuu
PaulYuuu requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@PaulYuuu PaulYuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the code flexible with less hard code, and don't provide internal info. cc @lijinlijin

@MiriamDeng
Copy link
Contributor Author

Thanks @PaulYuuu will move the parameter to the internal cfg.

@MiriamDeng
Copy link
Contributor Author

Test results
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.x86_64.io-github-autotest-qemu.in_place_upgrade.without_rhsm_rhel8_to_rhel9.stream_install.q35: STARTED
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.x86_64.io-github-autotest-qemu.in_place_upgrade.without_rhsm_rhel8_to_rhel9.stream_install.q35: PASS (2772.47 s)

@MiriamDeng
Copy link
Contributor Author

@fbq815 could you also help to review this patch ?

PaulYuuu
PaulYuuu reviewed Jul 30, 2024
View reviewed changes
qemu/tests/cfg/in_place_upgrade.cfg
@@ -53,6 +53,8 @@
- compose_install:
com_install = "yes"
com_ins_leapp = "yum install leapp-upgrade -y"
- stream_install:
# Please modify the build in the internal cfg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should add an example rather than point to internal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@MiriamDeng MiriamDeng force-pushed the stream_install branch 2 times, most recently from 48f9979 to 5e23f7b Compare August 13, 2024 06:02
@MiriamDeng
Copy link
Contributor Author

Updated. Can you help to review it ? Thank you !

@MiriamDeng
IPU:add stream installation way for leapp tool
f7f55c3 
ID:2634

Signed-off-by: Miriam Deng <mdeng@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulYuuu PaulYuuu PaulYuuu requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiriamDeng @PaulYuuu