Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - loadWebVTTSubtitlesAtURL #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feature - loadWebVTTSubtitlesAtURL #1

wants to merge 11 commits into from

Conversation

allenlinli
Copy link
Contributor

@allenlinli allenlinli commented May 28, 2018 •
edited
Loading

Add new function - (void)loadWebVTTSubtitlesAtURL:(NSURL *)url error:(NSError **)error, so ASBPlayerSubtitling.h accepts WebVTT.

Re-install pod to make project compilable.

@allenlinli
Copy link
Contributor Author

Hi @autresphere I wonder if this PR is ok now?
I removed the part of PR that change the original API, it should be ok now.

@autresphere
Copy link
Owner

Hi @allenlinli, this looks really good, thanks a lot!
There is now an issue with Travis CI, I guess the test command is too old and should be updated. Would you be kind enough to update it? I don't have time to have a look at it before several weeks.

@allenlinli allenlinli changed the title Feature - WebVTT to SRT Feature - loadWebVTTSubtitlesAtURL Jul 17, 2018
@allenlinli
Copy link
Contributor Author

I probably cannot fix Travis CI when I on work, I want to have a look when I am off work.
I have no experience with Travis CI. Where can I edit the Travis CI shell script?

@allenlinli allenlinli mentioned this pull request Jul 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allenlinli @autresphere