-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't install existing apps during quick install unless forced #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea ! Thanks!
let mut release_list = helper_menus::multiple_select_menu( | ||
"Select the versions you want to download :", | ||
release_list, | ||
) { | ||
Ok(release_list) => release_list, | ||
Err(e) => { | ||
eprintln!("The tag list could not be processed.\nError: {}", e); | ||
vec![] | ||
} | ||
}; | ||
).unwrap_or_else(|e| { | ||
eprintln!("The tag list could not be processed.\nError: {}", e); | ||
vec![] | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain on this, but I think someone on the Rust discord said unwrap_or_else might be worse for performance because it will run the closure inside of else even if the unwrap is successful, which doesn't happen with a match. I'm not sure if any of that's true however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that performance would matter in this case anyways. But still, I might revert this back to a match someday.
Sorry for taking this long to check your PR. I had way too many work notifications in my github. I will merge it right now. |
No description provided.