CreateWebserviceException() fix when 503 BadGataway status code received #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch and straight forward fix! Thank you! I will publish a patch release on Nuget in the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the website is down for maintenance, it returns the 503 error code and the following page causing MusicBrainzClient to throw the System.Runtime.Serialization.SerializationException exception with the following message instead of WebServiceException:
There was an error deserializing the object of type Hqub.MusicBrainz.MusicBrainzClient+ResponseError. Encountered unexpected character '<'.The fix catches any exception that may occur during deserialization and throws the WebServiceException exception instead with the status code as a message.
This is the 503 response page from MusicBrainz: