Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/Time header link in TOC broken on awesome-go.com #1224

Closed
willfaught opened this issue Dec 14, 2016 · 8 comments
Closed

Date/Time header link in TOC broken on awesome-go.com #1224

willfaught opened this issue Dec 14, 2016 · 8 comments

Comments

@willfaught
Copy link

  • Date/Time header link in TOC doesn't work
  • ORM list appears as a paragraph, not a list
@dmitshur
Copy link
Collaborator

ORM list appears as a paragraph, not a list

Can't reproduce. It seems fine to me:

image

Goroutines section, on the other hand, does have an issue:

image

@willfaught
Copy link
Author

Woops, you're right. It was the goroutine section that had the paragraph problem.

dmitshur added a commit that referenced this issue Dec 15, 2016
@dmitshur
Copy link
Collaborator

Ok, I've fixed that second issue in b9ad39e. Goroutines section now looks okay:

image

@willfaught
Copy link
Author

willfaught commented Dec 15, 2016 via email

@dmitshur
Copy link
Collaborator

I can. That's why this issue is still open.

@dmitshur dmitshur changed the title Date/Time and ORM broken on awesome-go.com Date/Time header link in TOC broken on awesome-go.com Dec 15, 2016
@dmitshur
Copy link
Collaborator

dmitshur commented Dec 15, 2016

It's not just "Date & Time" link, it's also "Generation & Generics", "Authentication & OAuth", and any other header with an ampersand.

It happens because of the difference in Markdown rendering between github.com and what is used on awesome-go.com. Compare:

https://github.com/avelino/awesome-go#date--time

http://awesome-go.com/#date-time

GitHub expects two dashes, but awesome-go.com one.

avelino pushed a commit that referenced this issue Apr 27, 2017
* fix gfm compat

Signed-off-by: Kirill Danshin <k@guava.by>

* fix .travis.yml

Signed-off-by: Kirill Danshin <k@guava.by>

* requested changes

Signed-off-by: Kirill Danshin <k@guava.by>
@dmitshur dmitshur mentioned this issue May 30, 2017
@dmitshur
Copy link
Collaborator

I got an idea for a temporary workaround fix.

We can just rename those heading not to include the problematic & symbol. I.e., use "Date and Time" rather than "Date & Time".

It wouldn't completely resolve the issue, but at least fix it for the users. It's easy and quick.

@cassiobotaro
Copy link
Collaborator

Fixed with #1505

cgxxv pushed a commit to cgxxv/awesome-go that referenced this issue Mar 25, 2022
cgxxv pushed a commit to cgxxv/awesome-go that referenced this issue Mar 25, 2022
* fix gfm compat

Signed-off-by: Kirill Danshin <k@guava.by>

* fix .travis.yml

Signed-off-by: Kirill Danshin <k@guava.by>

* requested changes

Signed-off-by: Kirill Danshin <k@guava.by>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants