-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date/Time header link in TOC broken on awesome-go.com #1224
Comments
Can't reproduce. It seems fine to me: Goroutines section, on the other hand, does have an issue: |
Woops, you're right. It was the goroutine section that had the paragraph problem. |
Ok, I've fixed that second issue in b9ad39e. Goroutines section now looks okay: |
Can you not reproduce the link issue?
…On Wed, Dec 14, 2016 at 5:15 PM Dmitri Shuralyov ***@***.***> wrote:
Ok, I've fixed that second issue in b9ad39e
<b9ad39e>.
Goroutines section now looks okay:
[image: image]
<https://cloud.githubusercontent.com/assets/1924134/21208113/faad145a-c239-11e6-9cb1-7ee18ee3a94a.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1224 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD5Vn6hSPzB4thDRt7LW5nhh17QZFrzks5rIJStgaJpZM4LNj6Q>
.
|
I can. That's why this issue is still open. |
It's not just "Date & Time" link, it's also "Generation & Generics", "Authentication & OAuth", and any other header with an ampersand. It happens because of the difference in Markdown rendering between github.com and what is used on awesome-go.com. Compare: https://github.com/avelino/awesome-go#date--time http://awesome-go.com/#date-time GitHub expects two dashes, but awesome-go.com one. |
I got an idea for a temporary workaround fix. We can just rename those heading not to include the problematic It wouldn't completely resolve the issue, but at least fix it for the users. It's easy and quick. |
Fixed with #1505 |
* fix gfm compat Signed-off-by: Kirill Danshin <k@guava.by> * fix .travis.yml Signed-off-by: Kirill Danshin <k@guava.by> * requested changes Signed-off-by: Kirill Danshin <k@guava.by>
The text was updated successfully, but these errors were encountered: