-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow creation of JS resolvers with S3 assets #2884
Draft
atierian
wants to merge
24
commits into
main
Choose a base branch
from
js-resolver.function-runtime-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+719
−531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
changed the title
refactor: allow creation of JS resolvers with via S3 Assets
refactor: allow creation of JS resolvers with S3 assets
Sep 18, 2024
Converted to draft while I explore a lower impact alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
No snapshots were harmed in the making of this PR.
No behavioral changes are included in this PR. This is prerequisite work to allow S3 asset JS resolver functions.
This is followup work to #2812.
Description of changes
Updates
addToSlot
to takeFunctionRuntimeTemplate
(reference)Adds
S3MappingJSResolverFunctionCode
class for JS runtime specificS3MappingTemplateProvider
(reference)Adds
MappingTemplate.s3MappingFunctionCodeFromString
function to allow creation of (S3) asset based JS runtime resolver functions. (reference)Updates
TransformerResolver
APIs and implementation to accept newFunctionRuntimeTemplate
type.Updates
TransformerResolver
API callsites in various transformers for newFunctionRuntimeTemplate
type. See commits for individual changes made to each transformer. Commit names follow the format"update <name>-transformer for FunctionRuntimeTemplate input"
for reviewing changes in isolation.Updates conversation and generation transformers to use
JSRuntimeTemplate
.Note
I recommend conducting a very surface level review of the conversation and generation changes. This PR is a prerequisite to two follow up PRs (for conversation and generation respectively) that migrate to using S3 asset based resolver functions. The majority of the conversation and generation transformer specific changes in this PR are again changed in these subsequent PRs. This was done to isolate the changes in the PR as much as possible, while not breaking the conversation and generation transformers.
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn test
passesRelevant documentation is changed or added (and PR referenced)New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policiesAny CDK or CloudFormation parameter changes are called out explicitlyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.