feat: adding support for karpenter blockdevicemapping #890
Conversation
paulmowat
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
There was a problem hiding this comment.
@paulmowat thank you for this contribution. Please see a couple relatively minor comments.
lib/addons/karpenter/index.ts
Outdated
| noDevice?: string; | ||
| } | ||
|
|
||
| interface Ebs { |
There was a problem hiding this comment.
Ebs is a bit too bold for this interface as it appears to represent ElasticBlockStorage as a service. How about either "EbsVolumeSettings|EbsVolumeMappingsor justEbsMappings`?
There was a problem hiding this comment.
thanks for the feedback. I've renamed to EBSVolumeMapping
lib/addons/karpenter/index.ts
Outdated
|
|
||
| interface BlockDeviceMapping { |
There was a problem hiding this comment.
These should be exported along with the KarpenterAddOnProps (not part of the PR atm) as customers will have issue consuming these otherwise. Let's add export keyword to all public data types.
There was a problem hiding this comment.
thanks for the feedback. I've exported all the interfaces (including KarpenterAddOnProps) and now use these as part of the unit test.
|
Validated with unit tests, e2e will be used with the upgraded versions of helm/cdk in the 1.13 release prep. |
Description of changes:
Adding in support to pass blockDeviceMappings through to karpenter as per https://karpenter.sh/v0.30/concepts/node-templates/#specblockdevicemappings
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.