Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Karpenter addon not return null for instanceStorePolicy as default #960

Merged

Conversation

vumdao
Copy link
Contributor

@vumdao vumdao commented Mar 15, 2024

Issue #, if available:

7:34:19 PM | UPDATE_FAILED        | Custom::AWSCDK-EKS-KubernetesResource | selvcd1deveksbluep...detemplate2CEE3EE4
Received response status [FAILED] from custom resource. Message returned: Error: b'The EC2NodeClass "default-ec2nodeclass" is invalid: \n* spec.instanceStorePolicy: Unsupported value: "": supported values: "RAID0"\n* <
nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation\n'

Logs: /aws/lambda/DeployDev-sel-vc-d1-dev-eks-bluepr-Handler886CB40B-h954A8KfTkdY

Description of changes:
Return null value for instanceStorePolicy as default value

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@youngjeong46 youngjeong46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR, this was missed on the last release.

LGTM!

@shapirov103
Copy link
Collaborator

Pending e2e. (Test account is in maintenance mode atm, ETA 1 day).

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@shapirov103 shapirov103 merged commit df89941 into aws-quickstart:main Mar 15, 2024
1 check passed
@vumdao
Copy link
Contributor Author

vumdao commented Mar 22, 2024

@shapirov103 When will we have a release/hotfix for this, my blueprint project is being failed without this.

@shapirov103
Copy link
Collaborator

@vumdao planning today or Monday.

@shapirov103
Copy link
Collaborator

1.14.1 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants