Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #997 - Enable control plane logging with CDK native (dropping custom resource) #998

Merged
merged 3 commits into from
May 3, 2024

Conversation

shapirov103
Copy link
Collaborator

Issue #, if available: #997

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator Author

Also addressing e2e for #996 and #991

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

elamaran11
elamaran11 previously approved these changes May 2, 2024
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator Author

Failed with Received response status [FAILED] from custom resource. Message returned: Cannot delete because cluster blueprint-construct-dev currently has update ed48a6c0-4b5e-492d-ae4e-f953bfecf921 in progress

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment @shapirov103

lib/utils/cluster-utils.ts Show resolved Hide resolved
@elamaran11 elamaran11 merged commit 4113e60 into main May 3, 2024
1 check passed
@elamaran11 elamaran11 deleted the bugfix/997 branch May 3, 2024 19:19
@shapirov103 shapirov103 changed the title Fix for #997 - set an option to install latest SDK Fix for #997 - Enable control plane logging with CDK native (dropping custom resource) May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants