Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable manual override for VERSION in images #1156

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

nprab428
Copy link

This change will allow you to pass a custom tag for CNI images as a VERSION command-line parameter. We will default to the old value if the param is not supplied.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nprab428 nprab428 requested a review from mogren August 20, 2020 23:52
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense to have this option.

Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants