Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code cleanup #1198

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Minor code cleanup #1198

merged 1 commit into from
Sep 12, 2020

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Sep 6, 2020

What type of PR is this?

cleanup

Why do we need it:
More idiomatic go

If issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
No issue

Testing:
Overriding the default values works, AWS_VPC_ENI_MTU=1500:

eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet 192.168.196.XX  netmask 255.255.224.0  broadcast 192.168.223.255
        inet6 fe80::8e8:51ff:fea1:cccc  prefixlen 64  scopeid 0x20<link>

eniab6a8de41e1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet6 fe80::64da:d0ff:fe28:1932  prefixlen 64  scopeid 0x20<link>
        ether 66:da:d0:28:19:32  txqueuelen 0  (Ethernet)

Deleting the config completely, we fall back to the default:

enic440f455693: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 9001
        inet6 fe80::147d:7eff:fef0:f2ed  prefixlen 64  scopeid 0x20<link>
        ether 16:7d:7e:f0:f2:ed  txqueuelen 0  (Ethernet)

Automation added to e2e:
No

Will this break upgrades and downgrades. Has it been tested?:
No

Does this change require any CNI config changes?:
No

Does this PR introduce a user-facing change?:
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren force-pushed the default-conf branch 3 times, most recently from 3e09a3e to 28a04db Compare September 10, 2020 00:48
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants