Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration update to v1.7.8 #1335

Merged
merged 2 commits into from
Dec 16, 2020
Merged

configuration update to v1.7.8 #1335

merged 2 commits into from
Dec 16, 2020

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Dec 16, 2020

What type of PR is this?
Configuration updates for v1.7.8 release

Which issue does this PR fix:
New release

What does this PR do / Why do we need it:
Update configuration files

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

No
Does this PR introduce any user-facing change?:

Yes

https://github.com/aws/amazon-vpc-cni-k8s/releases

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haouc haouc requested a review from jayanthvn December 16, 2020 06:56
@@ -32,7 +32,12 @@ spec:
# container programs network policy and routes on each
# host.
- name: calico-node
image: quay.io/calico/node:v3.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have calico config changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have calico copied from master to v1.7. Seems we didn't do that in previous release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master/calico has some changes which needs to be merged to release-1.7. Changes will be merge to release-1.7 in the next release.

@haouc haouc requested a review from jayanthvn December 16, 2020 16:54
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@haouc haouc merged commit c1658d5 into aws:release-1.7 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants