Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade github.com/containernetworking/plugins to v0.9.0 #1350

Merged
merged 1 commit into from
Jan 21, 2021
Merged

upgrade github.com/containernetworking/plugins to v0.9.0 #1350

merged 1 commit into from
Jan 21, 2021

Conversation

fr0stbyte
Copy link
Contributor

What type of PR is this?
feature

Which issue does this PR fix:

containernetworking/plugins#553

What does this PR do / Why do we need it:

conntrack table is not flushed for UDP hostPorts when pod is deleted. This has been fixed in the newer version of containernetworking/plugins (PR with the fix is linked above)

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

n/a

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Not tested beyond unittests

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:
Not that I am aware of

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@fawadkhaliq fawadkhaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++, thanks for updating the dependency

This will need an e2e integration test run and then it's good to merge. (cc: @jayanthvn @couralex6 - I know you're updating the CI workers, can we please trigger the on-demand test on this PR)

Here's the changelog for the plugins v0.9.0 release: https://github.com/containernetworking/plugins/releases/tag/v0.9.0

Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for integration test run then I will merge. Thanks for taking care of this.

@fr0stbyte
Copy link
Contributor Author

@jayanthvn @fawadkhaliq rebased the PR.

@jayanthvn jayanthvn merged commit 6b84a54 into aws:master Jan 21, 2021
@jayanthvn
Copy link
Contributor

Thanks for taking care of it. I will merge and run integration test on this thru circle ci.

@fr0stbyte fr0stbyte deleted the fr0stbyte/containernetworking_plugins branch January 22, 2021 17:05
@couralex6
Copy link
Contributor

@fr0stbyte Were you able to verify if this fix solves your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants