Faster eni scaleup #2744
Merged
Faster eni scaleup #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Jan 5, 2024
jchen6585
force-pushed
the
refactor-incDS
branch
2 times, most recently
from
5acf19f
to
91a0731
Compare
jdn5126
reviewed
Jan 8, 2024
jchen6585
force-pushed
the
refactor-incDS
branch
from
91a0731
to
c237d34
Compare
jdn5126
suggested changes
Jan 10, 2024
jchen6585
force-pushed
the
refactor-incDS
branch
from
c237d34
to
04774d6
Compare
jdn5126
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
We would previously allocate 1 ENI max per loop: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/ipamd/ipamd.go#L621-L628
This PR modifies the
updateIpPoolIfRequiredfunction to have faster ENI scale up to avoid the 5 second sleep.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
CNI suite: passing
IPAMD suite: passing
Will this PR introduce any new dependencies?:
N/A
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.